[llvm] [LLVM][DWARF] Create debug names entry for non-tu top level DIE (PR #121856)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 11:08:49 PST 2025


================
@@ -589,7 +589,8 @@ DIE *DwarfUnit::createTypeDIE(const DIScope *Context, DIE &ContextDIE,
       // Skip updating the accelerator tables since this is not the full type.
       if (MDString *TypeId = CTy->getRawIdentifier()) {
         addGlobalType(Ty, TyDIE, Context);
-        DD->addDwarfTypeUnitType(getCU(), TypeId->getString(), TyDIE, CTy);
+        if (DD->addDwarfTypeUnitType(getCU(), TypeId->getString(), TyDIE, CTy))
+          updateAcceleratorTables(Context, Ty, TyDIE);
----------------
dwblaikie wrote:

Why not add this to the addDwarfTypeUnitType function, rather than returning then adding here?

https://github.com/llvm/llvm-project/pull/121856


More information about the llvm-commits mailing list