[libcxx] [llvm] [ci] Bump the version of clang-format used in the CI (PR #119915)

Louis Dionne via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 10:07:09 PST 2025


https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/119915

>From 7e1fdd375d49154f6d0ceeb6aa96faaf77c43df3 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Fri, 13 Dec 2024 14:04:24 -0500
Subject: [PATCH 1/3] [ci] Bump the version of clang-format used in the CI

The version of clang-format we use in the CI to format all
PRs is a bit outdated, leading to some confusion when the
CI job produces different output from what people have locally.

We should decide on a policy for updating this version since
it impacts the whole monorepo, and we should document the version
currently in use somewhere (in the Contributing docs?). We should
also decide on a policy for whether to re-apply clang-format to
the whole codebase whenever we change this version.
---
 .github/workflows/pr-code-format.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/pr-code-format.yml b/.github/workflows/pr-code-format.yml
index f2bb37316d3a8b..5eb017737e853d 100644
--- a/.github/workflows/pr-code-format.yml
+++ b/.github/workflows/pr-code-format.yml
@@ -60,7 +60,7 @@ jobs:
       - name: Install clang-format
         uses: aminya/setup-cpp at v1
         with:
-          clangformat: 18.1.7
+          clangformat: 19.1.5
 
       - name: Setup Python env
         uses: actions/setup-python at v5

>From 5f7ab49853062ea44eabec390555f901af6af6d1 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Tue, 7 Jan 2025 12:55:40 -0500
Subject: [PATCH 2/3] Use 19.1.6 instead

---
 .github/workflows/pr-code-format.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/pr-code-format.yml b/.github/workflows/pr-code-format.yml
index 5eb017737e853d..0e6180acf4a468 100644
--- a/.github/workflows/pr-code-format.yml
+++ b/.github/workflows/pr-code-format.yml
@@ -60,7 +60,7 @@ jobs:
       - name: Install clang-format
         uses: aminya/setup-cpp at v1
         with:
-          clangformat: 19.1.5
+          clangformat: 19.1.6
 
       - name: Setup Python env
         uses: actions/setup-python at v5

>From 2d086d51b50de4572bdda003fc645145054bb317 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Tue, 7 Jan 2025 13:06:53 -0500
Subject: [PATCH 3/3] WIP: Try to trigger formatting job just to test

---
 libcxx/include/__new/destroying_delete_t.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libcxx/include/__new/destroying_delete_t.h b/libcxx/include/__new/destroying_delete_t.h
index 7fca4f6c68b212..1596c71bcd2efa 100644
--- a/libcxx/include/__new/destroying_delete_t.h
+++ b/libcxx/include/__new/destroying_delete_t.h
@@ -21,7 +21,8 @@ namespace std {
 // Enable the declaration even if the compiler doesn't support the language
 // feature.
 struct destroying_delete_t {
-  explicit destroying_delete_t() = default;
+  explicit destroying_delete_t() =
+  default;
 };
 inline constexpr destroying_delete_t destroying_delete{};
 } // namespace std



More information about the llvm-commits mailing list