[llvm] 1332db3 - [DAG] TransformFPLoadStorePair - early out if we're not loading a simple type

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 05:37:46 PST 2025


Author: Simon Pilgrim
Date: 2025-01-07T13:37:23Z
New Revision: 1332db36ee23f19eacf6a84bfda0f9c03a5706e7

URL: https://github.com/llvm/llvm-project/commit/1332db36ee23f19eacf6a84bfda0f9c03a5706e7
DIFF: https://github.com/llvm/llvm-project/commit/1332db36ee23f19eacf6a84bfda0f9c03a5706e7.diff

LOG: [DAG] TransformFPLoadStorePair - early out if we're not loading a simple type

Its never going to transform into a legal integer type, so just bail - noticed while triaging the assertion reported in #121784

Added: 
    

Modified: 
    llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
index e89e7efa98c1af..6ea9e68a3a0054 100644
--- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -20455,10 +20455,8 @@ SDValue DAGCombiner::TransformFPLoadStorePair(SDNode *N) {
       Value.hasOneUse()) {
     LoadSDNode *LD = cast<LoadSDNode>(Value);
     EVT VT = LD->getMemoryVT();
-    if (!VT.isFloatingPoint() ||
-        VT != ST->getMemoryVT() ||
-        LD->isNonTemporal() ||
-        ST->isNonTemporal() ||
+    if (!VT.isSimple() || !VT.isFloatingPoint() || VT != ST->getMemoryVT() ||
+        LD->isNonTemporal() || ST->isNonTemporal() ||
         LD->getPointerInfo().getAddrSpace() != 0 ||
         ST->getPointerInfo().getAddrSpace() != 0)
       return SDValue();


        


More information about the llvm-commits mailing list