[compiler-rt] [Darwin][CompilerRT] Set compiler ID to 'Clang' for Compiler RT Tests for Apple Clang (PR #121858)

Alexander Richardson via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 6 21:48:29 PST 2025


https://github.com/arichardson approved this pull request.

Ah I missed the `config.available_features.add(compiler_id)`. I agree we should normalize this to clang either in cmake or the top-level lit config file.

I'd prefer to do the canonicalization at the end of this if-else chain for future proofing, i.e

```
if ("${COMPILER_RT_TEST_COMPILER_ID}" STREQUAL "AppleClang")
    # Compiler-rt lit tests expect compiler ID 'Clang' for AppleClang.
    set(COMPILER_RT_TEST_COMPILER_ID Clang)
  endif()
```
but I guess the current one is fine too.

https://github.com/llvm/llvm-project/pull/121858


More information about the llvm-commits mailing list