[llvm] [libc-utils] disable target_compile_features (PR #121883)

Brian Cain via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 6 19:43:35 PST 2025


https://github.com/androm3da created https://github.com/llvm/llvm-project/pull/121883

Having `cxx_std_17` enabled here causes runtimes build failures that fail like so:

    CMake Error in /home/user/src/llvm-project/libcxx/src/CMakeLists.txt:
      No known features for CXX compiler

      "Clang"

      version 20.0.0.

We'll disable this for now and look into a new fix.

Fixes: 114591

>From e550722c40b0980c419eb5b38bab7a0875ca1aa7 Mon Sep 17 00:00:00 2001
From: Brian Cain <brian.cain at oss.qualcomm.com>
Date: Mon, 6 Jan 2025 19:40:51 -0800
Subject: [PATCH] [libc-utils] disable target_compile_features

Having `cxx_std_17` enabled here causes runtimes build failures that fail
like so:

    CMake Error in /home/user/src/llvm-project/libcxx/src/CMakeLists.txt:
      No known features for CXX compiler

      "Clang"

      version 20.0.0.

We'll disable this for now and look into a new fix.

Fixes: 114591
---
 runtimes/cmake/Modules/FindLibcCommonUtils.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/runtimes/cmake/Modules/FindLibcCommonUtils.cmake b/runtimes/cmake/Modules/FindLibcCommonUtils.cmake
index 0e65fdff7c34b9..562639a619f099 100644
--- a/runtimes/cmake/Modules/FindLibcCommonUtils.cmake
+++ b/runtimes/cmake/Modules/FindLibcCommonUtils.cmake
@@ -14,6 +14,6 @@ if(NOT TARGET llvm-libc-common-utilities)
     # adding the root "libc" directory to the include path.
     target_include_directories(llvm-libc-common-utilities INTERFACE ${libc_path})
     target_compile_definitions(llvm-libc-common-utilities INTERFACE LIBC_NAMESPACE=__llvm_libc_common_utils)
-    target_compile_features(llvm-libc-common-utilities INTERFACE cxx_std_17)
+#   target_compile_features(llvm-libc-common-utilities INTERFACE cxx_std_17)
   endif()
 endif()



More information about the llvm-commits mailing list