[lld] [lld-macho,BalancedPartition] Simplify relocation hash and avoid xxHash (PR #121729)
Ellis Hoag via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 6 14:49:40 PST 2025
================
@@ -91,22 +94,20 @@ class BPSectionMacho : public BPSectionBase {
constexpr unsigned windowSize = 4;
// Calculate content hashes
- size_t dataSize = isec->data.size();
- for (size_t i = 0; i < dataSize; i++) {
- auto window = isec->data.drop_front(i).take_front(windowSize);
- hashes.push_back(xxHash64(window));
- }
+ ArrayRef<uint8_t> data = isec->data;
+ for (size_t i = 0; i <= data.size() - windowSize; i++)
+ hashes.push_back(llvm::support::endian::read32le(data.data() + i));
----------------
ellishg wrote:
This changes how we take hashes at the end of the section, but it could be a change for the better. I'm testing this PR on our apps to see if there is a size regression or not
https://github.com/llvm/llvm-project/pull/121729
More information about the llvm-commits
mailing list