[clang] [llvm] [HLSL] Move length support out of the DirectX Backend (PR #121611)

Farzon Lotfi via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 6 10:37:15 PST 2025


================
@@ -1,73 +1,151 @@
-// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \
-// RUN:   dxil-pc-shadermodel6.3-library %s -fnative-half-type \
-// RUN:   -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ 
-// RUN:   --check-prefixes=CHECK,NATIVE_HALF
-// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \
-// RUN:   dxil-pc-shadermodel6.3-library %s -emit-llvm -disable-llvm-passes \
-// RUN:   -o - | FileCheck %s --check-prefixes=CHECK,NO_HALF
----------------
farzonl wrote:

I switched to have this file updated via `update_cc_test_checks.py` instead of manually written to save time writing tests. Keeping the NO_HALF variant was resulting in a lot of check duplication with very little benefit. We have plenty of other tests that check that a float will become a half without the `fnative-half-type` flag. I think we should probably update all the the tests to get ride of NO_HALF and just have one test that checks this flag is working as intended. 

https://github.com/llvm/llvm-project/pull/121611


More information about the llvm-commits mailing list