[llvm] [RISCV] Don't commute with shift if it would break sh{1,2,3}add pattern (PR #119527)

[Yingwei Zheng via llvm-commits]

dtcxzyw wrote:

Can you rebase on the top of https://github.com/llvm/llvm-project/pull/120531?
```
FAILED: lib/Target/RISCV/CMakeFiles/LLVMRISCVCodeGen.dir/RISCVISelLowering.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/zyw/codegen/actions-runner/_work/llvm-codegen-benchmark/llvm-codegen-benchmark/llvm/llvm-build/lib/Target/RISCV -I/data/zyw/codegen/actions-runner/_work/llvm-codegen-benchmark/llvm-codegen-benchmark/llvm/llvm-project/llvm/lib/Target/RISCV -I/data/zyw/codegen/actions-runner/_work/llvm-codegen-benchmark/llvm-codegen-benchmark/llvm/llvm-build/include -I/data/zyw/codegen/actions-runner/_work/llvm-codegen-benchmark/llvm-codegen-benchmark/llvm/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -w -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Target/RISCV/CMakeFiles/LLVMRISCVCodeGen.dir/RISCVISelLowering.cpp.o -MF lib/Target/RISCV/CMakeFiles/LLVMRISCVCodeGen.dir/RISCVISelLowering.cpp.o.d -o lib/Target/RISCV/CMakeFiles/LLVMRISCVCodeGen.dir/RISCVISelLowering.cpp.o -c /data/zyw/codegen/actions-runner/_work/llvm-codegen-benchmark/llvm-codegen-benchmark/llvm/llvm-project/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
/data/zyw/codegen/actions-runner/_work/llvm-codegen-benchmark/llvm-codegen-benchmark/llvm/llvm-project/llvm/lib/Target/RISCV/RISCVISelLowering.cpp: In member function ‘virtual bool llvm::RISCVTargetLowering::isDesirableToCommuteWithShift(const llvm::SDNode*, llvm::CombineLevel) const’:
/data/zyw/codegen/actions-runner/_work/llvm-codegen-benchmark/llvm-codegen-benchmark/llvm/llvm-project/llvm/lib/Target/RISCV/RISCVISelLowering.cpp:18393: error: ‘class llvm::SDUse’ has no member named ‘getOpcode’; did you mean ‘getNode’?
18393 |         N->use_begin()->getOpcode() == ISD::ADD &&
      | 
/data/zyw/codegen/actions-runner/_work/llvm-codegen-benchmark/llvm-codegen-benchmark/llvm/llvm-project/llvm/lib/Target/RISCV/RISCVISelLowering.cpp:18394: error: no match for call to ‘(llvm::RISCVTargetLowering::isDesirableToCommuteWithShift(const llvm::SDNode*, llvm::CombineLevel) const::<lambda(const llvm::SDNode*, const llvm::SDNode*)>) (llvm::SDUse&, std::nullptr_t)’
18394 |         !isUsedByLdSt(*N->use_begin(), nullptr) &&
      | 
/data/zyw/codegen/actions-runner/_work/llvm-codegen-benchmark/llvm-codegen-benchmark/llvm/llvm-project/llvm/lib/Target/RISCV/RISCVISelLowering.cpp:18394: note: candidate: ‘bool (*)(const llvm::SDNode*, const llvm::SDNode*)’ (conversion)
/data/zyw/codegen/actions-runner/_work/llvm-codegen-benchmark/llvm-codegen-benchmark/llvm/llvm-project/llvm/lib/Target/RISCV/RISCVISelLowering.cpp:18394: note:   candidate expects 3 arguments, 3 provided
/data/zyw/codegen/actions-runner/_work/llvm-codegen-benchmark/llvm-codegen-benchmark/llvm/llvm-project/llvm/lib/Target/RISCV/RISCVISelLowering.cpp:18371: note: candidate: ‘llvm::RISCVTargetLowering::isDesirableToCommuteWithShift(const llvm::SDNode*, llvm::CombineLevel) const::<lambda(const llvm::SDNode*, const llvm::SDNode*)>’
18371 |   auto isUsedByLdSt = [](const SDNode *X, const SDNode *User) {
      | 
/data/zyw/codegen/actions-runner/_work/llvm-codegen-benchmark/llvm-codegen-benchmark/llvm/llvm-project/llvm/lib/Target/RISCV/RISCVISelLowering.cpp:18371: note:   no known conversion for argument 1 from ‘llvm::SDUse’ to ‘const llvm::SDNode*’
/data/zyw/codegen/actions-runner/_work/llvm-codegen-benchmark/llvm-codegen-benchmark/llvm/llvm-project/llvm/lib/Target/RISCV/RISCVISelLowering.cpp:18395: error: ‘class llvm::SDUse’ has no member named ‘getOperand’; did you mean ‘getOperandNo’?
18395 |         !isa<ConstantSDNode>(N->use_begin()->getOperand(1)))
      | 
ninja: build stopped: subcommand failed.
```

https://github.com/llvm/llvm-project/pull/119527