[llvm] [RISCV] Allow tail memcmp expansion (PR #121460)

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 08:43:48 PST 2025


preames wrote:

> What are the soundness issues? I thought we only had costing issues?
> 
> The code in `RISCVTTIImpl::enableMemCmpExpansion` currently checks `ST->enableUnalignedScalarMem()` before enabling any expansion.

Gah, you're correct!  I read the check code too fast and apparently mentally placed the negate in the wrong place.  Please ignore my comment on this review entirely. 

https://github.com/llvm/llvm-project/pull/121460


More information about the llvm-commits mailing list