[llvm] [TableGen] Avoid repeated hash lookups (NFC) (PR #120619)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 19 10:30:26 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-tablegen
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/120619.diff
1 Files Affected:
- (modified) llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp (+1-2)
``````````diff
diff --git a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
index 193d29717d2c96..1a393beaa14f96 100644
--- a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
+++ b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
@@ -3290,10 +3290,9 @@ void CodeGenDAGPatterns::ParsePatternFragments(bool OutFrags) {
if (!OpsList->getArgName(j))
P->error("Operands list should have names for each operand!");
StringRef ArgNameStr = OpsList->getArgNameStr(j);
- if (!OperandsSet.count(ArgNameStr))
+ if (!OperandsSet.erase(ArgNameStr))
P->error("'" + ArgNameStr +
"' does not occur in pattern or was multiply specified!");
- OperandsSet.erase(ArgNameStr);
Args.push_back(std::string(ArgNameStr));
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/120619
More information about the llvm-commits
mailing list