[llvm] [TableGen] Avoid repeated hash lookups (NFC) (PR #120619)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 19 10:29:53 PST 2024
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/120619
None
>From ab23c2ed8add32ea08ba6e89f264498209290456 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Thu, 19 Dec 2024 10:19:26 -0800
Subject: [PATCH] [TableGen] Avoid repeated hash lookups (NFC)
---
llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
index 193d29717d2c96..1a393beaa14f96 100644
--- a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
+++ b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
@@ -3290,10 +3290,9 @@ void CodeGenDAGPatterns::ParsePatternFragments(bool OutFrags) {
if (!OpsList->getArgName(j))
P->error("Operands list should have names for each operand!");
StringRef ArgNameStr = OpsList->getArgNameStr(j);
- if (!OperandsSet.count(ArgNameStr))
+ if (!OperandsSet.erase(ArgNameStr))
P->error("'" + ArgNameStr +
"' does not occur in pattern or was multiply specified!");
- OperandsSet.erase(ArgNameStr);
Args.push_back(std::string(ArgNameStr));
}
More information about the llvm-commits
mailing list