[llvm] [Github] Fix windows container push (PR #119916)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 11:16:09 PST 2024


https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/119916

The windows container push was not tested in the pull request and had a couple of typos that prevented it from functioning. This patch fixes that so we can actually push the container to GHCR.

>From d9074ba6519ee09b5f218e1378d32216de9eca55 Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Fri, 13 Dec 2024 19:09:14 +0000
Subject: [PATCH] [Github] Fix windows container push

The windows container push was not tested in the pull request and had a
couple of typos that prevented it from functioning. This patch fixes
that so we can actually push the container to GHCR.
---
 .github/workflows/build-ci-container-windows.yml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/build-ci-container-windows.yml b/.github/workflows/build-ci-container-windows.yml
index 898cdce097e97e..6671ceeec5e0e0 100644
--- a/.github/workflows/build-ci-container-windows.yml
+++ b/.github/workflows/build-ci-container-windows.yml
@@ -53,7 +53,7 @@ jobs:
           retention-days: 14
   
   push-ci-container:
-    if: github.event_name == 'push'
+    #if: github.event_name == 'push'
     needs:
       - build-ci-container-windows
     permissions:
@@ -68,8 +68,8 @@ jobs:
           name: container
       - name: Push Container
         run: |
-          docker load -i ${{ needs.build-ci-container.outptus.container-filename }}
+          docker load -i ${{ needs.build-ci-container-windows.outputs.container-filename }}
           docker tag ${{ steps.vars.outputs.container-name-tag }} ${{ steps.vars.outputs.container-name }}:latest
           docker login -u ${{ github.actor }} -p $env:GITHUB_TOKEN ghcr.io
-          docker push ${{ needs.build-ci-container.outputs.container-name-tag }}
-          docker push ${{ needs.build-ci-container.outputs.container-name }}:latest
+          docker push ${{ needs.build-ci-container-windows.outputs.container-name-tag }}
+          docker push ${{ needs.build-ci-container-windows.outputs.container-name }}:latest



More information about the llvm-commits mailing list