[lld] [LLD][COFF] Store reference to SymbolTable instead of COFFLinkerContext in InputFile (NFC) (PR #119296)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 05:21:36 PST 2024


================
@@ -403,8 +404,8 @@ class BitcodeFile : public InputFile {
 // .dll file. MinGW only.
 class DLLFile : public InputFile {
 public:
-  explicit DLLFile(COFFLinkerContext &ctx, MemoryBufferRef m)
-      : InputFile(ctx, DLLKind, m) {}
+  explicit DLLFile(SymbolTable &symtab, MemoryBufferRef m)
----------------
mstorsjo wrote:

Ok, after reading the fourth commit, I see - the default is to keep passing `ctx` as we don't really know which symbol table it belong to yet, while the cases here where we already pass a known `SymbolTable` is more of a special case, where we seem to know for sure beforehand which symbol table it belongs to?

https://github.com/llvm/llvm-project/pull/119296


More information about the llvm-commits mailing list