[llvm] [GlobalISel][AArch64] Legalize G_FABS and G_FNEG for SVE (PR #114784)

[Amara Emerson via llvm-commits]

Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>,
Thorsten =?utf-8?q?Schütt?= <schuett at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/114784 at github.com>


aemerson wrote:

> +1.
> 
> I think we should have a RFC for this. The plan for SVE implementation should be spelled out at some point. How are we approaching this? What pieces can be reused? I understand that we have some patches in the community (including some from my team) but we should take a moment and write down at least a rough plan

> I think a proper design for how global-isel can represent predicated instructions is required. 

This PR is sort of jumping the gun at the moment, and we'll never have a clear project that other people or teams can join the effort without a better thought out plan. @madhur13490 asked for an RFC of a design, of which a PR can be used as an example proof-of-concept. I think multiple people on this PR (not just me) are recommending we take a step back and do design work first. Otherwise just merging in code is a liability.

https://github.com/llvm/llvm-project/pull/114784