[llvm] [RISCV][VLOPT] Add support for more instructions in vl-opt-op-info.mir (PR #119416)

Luke Lau via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 11 07:32:15 PST 2024


lukel97 wrote:

> > The existing vop_vv_* test cases should cover the EEW=SEW EMUL=EMUL format instructions.
> 
> > 
> 
> > I think the original structure of this test was to test the various formats/combinations of EEW and EMUL, but with that said I'm not opposed if we want to test specific opcodes either
> 
> 
> 
> While its true that we cover the return statements in getOperandInfo already, this patch adds some tests for instructions that definitely have different properties than whats currently being tested. Just because an instruction is grouped up with a common return statement, it doesn't mean that it actually belongs there. I'd like to build this test up over time to get increased confidence that instructions grouped under a common return statement actually belong there.

That sounds reasonable to me

https://github.com/llvm/llvm-project/pull/119416


More information about the llvm-commits mailing list