[llvm] 9b6bb83 - Revert "CallPromotionUtils: Correctly use IndexSize when determining the bit width of pointer offsets. (#119138)"

[Owen Anderson via llvm-commits]

Author: Owen Anderson
Date: 2024-12-11T13:20:17+13:00
New Revision: 9b6bb8386001a1d308cda42fe273733e58b8e93e

URL: https://github.com/llvm/llvm-project/commit/9b6bb8386001a1d308cda42fe273733e58b8e93e
DIFF: https://github.com/llvm/llvm-project/commit/9b6bb8386001a1d308cda42fe273733e58b8e93e.diff

LOG: Revert "CallPromotionUtils: Correctly use IndexSize when determining the bit width of pointer offsets. (#119138)"

Reverting due to ASAN bootstrap failures.

This reverts commit 4027e2f248044d944aaf3d9bc9c8eb6928506d44.

Added: 
    

Modified: 
    llvm/lib/Transforms/Utils/CallPromotionUtils.cpp

Removed: 
    llvm/test/Transforms/Inline/promote-call-bitwidth.ll


################################################################################
diff  --git a/llvm/lib/Transforms/Utils/CallPromotionUtils.cpp b/llvm/lib/Transforms/Utils/CallPromotionUtils.cpp
index f8ebf962bd4aa3..17cba2e642a19a 100644
--- a/llvm/lib/Transforms/Utils/CallPromotionUtils.cpp
+++ b/llvm/lib/Transforms/Utils/CallPromotionUtils.cpp
@@ -692,14 +692,14 @@ bool llvm::tryPromoteCall(CallBase &CB) {
   if (!VTableEntryLoad)
     return false; // Not a vtable entry load.
   Value *VTableEntryPtr = VTableEntryLoad->getPointerOperand();
-  APInt VTableOffset(DL.getIndexTypeSizeInBits(VTableEntryPtr->getType()), 0);
+  APInt VTableOffset(DL.getTypeSizeInBits(VTableEntryPtr->getType()), 0);
   Value *VTableBasePtr = VTableEntryPtr->stripAndAccumulateConstantOffsets(
       DL, VTableOffset, /* AllowNonInbounds */ true);
   LoadInst *VTablePtrLoad = dyn_cast<LoadInst>(VTableBasePtr);
   if (!VTablePtrLoad)
     return false; // Not a vtable load.
   Value *Object = VTablePtrLoad->getPointerOperand();
-  APInt ObjectOffset(DL.getIndexTypeSizeInBits(Object->getType()), 0);
+  APInt ObjectOffset(DL.getTypeSizeInBits(Object->getType()), 0);
   Value *ObjectBase = Object->stripAndAccumulateConstantOffsets(
       DL, ObjectOffset, /* AllowNonInbounds */ true);
   if (!(isa<AllocaInst>(ObjectBase) && ObjectOffset == 0))
@@ -712,7 +712,7 @@ bool llvm::tryPromoteCall(CallBase &CB) {
       VTablePtrLoad, VTablePtrLoad->getParent(), BBI, 0, nullptr, nullptr);
   if (!VTablePtr)
     return false; // No vtable found.
-  APInt VTableOffsetGVBase(DL.getIndexTypeSizeInBits(VTablePtr->getType()), 0);
+  APInt VTableOffsetGVBase(DL.getTypeSizeInBits(VTablePtr->getType()), 0);
   Value *VTableGVBase = VTablePtr->stripAndAccumulateConstantOffsets(
       DL, VTableOffsetGVBase, /* AllowNonInbounds */ true);
   GlobalVariable *GV = dyn_cast<GlobalVariable>(VTableGVBase);

diff  --git a/llvm/test/Transforms/Inline/promote-call-bitwidth.ll b/llvm/test/Transforms/Inline/promote-call-bitwidth.ll
deleted file mode 100644
index 6a0ddb56012535..00000000000000
--- a/llvm/test/Transforms/Inline/promote-call-bitwidth.ll
+++ /dev/null
@@ -1,48 +0,0 @@
-; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --scrub-attributes
-; RUN: opt -S -passes=inline < %s | FileCheck %s
-
-;; Check that we correctly use the index size when accumulating offsets during CallPromotion
-
-target datalayout = "p200:128:128:128:64-A200-P200-G200"
-
-define void @test(ptr addrspace(200) %arg1, ptr addrspace(200) %arg2) local_unnamed_addr addrspace(200) {
-; CHECK-LABEL: define {{[^@]+}}@test
-; CHECK-SAME: (ptr addrspace(200) [[ARG1:%.*]], ptr addrspace(200) [[ARG2:%.*]]) local_unnamed_addr addrspace(200) {
-; CHECK-NEXT:  entry:
-; CHECK-NEXT:    [[TMP0:%.*]] = load ptr addrspace(200), ptr addrspace(200) [[ARG2]], align 16
-; CHECK-NEXT:    call addrspace(200) void [[TMP0]](ptr addrspace(200) [[ARG1]])
-; CHECK-NEXT:    ret void
-;
-entry:
-  call void @call_fnptr(ptr addrspace(200) %arg1, ptr addrspace(200) %arg2)
-  ret void
-}
-
-define internal void @call_fnptr(ptr addrspace(200) %this, ptr addrspace(200) %arg) unnamed_addr addrspace(200) align 2 {
-entry:
-  %0 = load ptr addrspace(200), ptr addrspace(200) %arg, align 16
-  call void %0(ptr addrspace(200) %this)
-  ret void
-}
-
-define void @test2(ptr addrspace(200) %this) local_unnamed_addr addrspace(200) {
-; CHECK-LABEL: define {{[^@]+}}@test2
-; CHECK-SAME: (ptr addrspace(200) [[THIS:%.*]]) local_unnamed_addr addrspace(200) {
-; CHECK-NEXT:  entry:
-; CHECK-NEXT:    [[VTABLE_I:%.*]] = load ptr addrspace(200), ptr addrspace(200) [[THIS]], align 16
-; CHECK-NEXT:    [[FN_I:%.*]] = load ptr addrspace(200), ptr addrspace(200) [[VTABLE_I]], align 16
-; CHECK-NEXT:    call addrspace(200) void [[FN_I]](ptr addrspace(200) [[THIS]])
-; CHECK-NEXT:    ret void
-;
-entry:
-  call void @call_via_vtable(ptr addrspace(200) %this)
-  ret void
-}
-
-define internal void @call_via_vtable(ptr addrspace(200) %this) unnamed_addr addrspace(200) {
-entry:
-  %vtable = load ptr addrspace(200), ptr addrspace(200) %this, align 16
-  %fn = load ptr addrspace(200), ptr addrspace(200) %vtable, align 16
-  call void %fn(ptr addrspace(200) %this)
-  ret void
-}