[clang] [llvm] [NVPTX] Add NVVMUpgradeAnnotations pass to cleanup legacy annotations (PR #119261)

[Artem Belevich via llvm-commits]

================
@@ -324,14 +326,17 @@ MaybeAlign getAlign(const Function &F, unsigned Index) {
           F.getAttributes().getAttributes(Index).getStackAlignment())
     return StackAlign;
 
-  // If that is missing, check the legacy nvvm metadata
-  std::vector<unsigned> Vs;
-  bool retval = findAllNVVMAnnotation(&F, "align", Vs);
-  if (!retval)
-    return std::nullopt;
-  for (unsigned V : Vs)
-    if ((V >> 16) == Index)
-      return Align(V & 0xFFFF);
+  // check the legacy nvvm metadata only for the return value since llvm does
+  // not support stackalign attribute for this.
+  if (Index == 0) {
+    std::vector<unsigned> Vs;
+    bool retval = findAllNVVMAnnotation(&F, "align", Vs);
+    if (!retval)
----------------
Artem-B wrote:

Nit: Instead of early return I'd put bool retval into `if(bool retval = ...)`. We're returning nullopt anyways at the end.

https://github.com/llvm/llvm-project/pull/119261