[clang] [llvm] [AArch64][FMV] Add missing feature dependencies and detect at runtime. (PR #119231)

[Alexandros Lamprineas via llvm-commits]

================
@@ -61,13 +61,13 @@ unsigned AArch64::getFMVPriority(ArrayRef<StringRef> Features) {
   return Priority + MaxFMVPriority * NumFeatures;
 }
 
-uint64_t AArch64::getCpuSupportsMask(ArrayRef<StringRef> FeatureStrs) {
-  uint64_t FeaturesMask = 0;
-  for (const StringRef &FeatureStr : FeatureStrs) {
-    if (auto Ext = parseFMVExtension(FeatureStr))
-      FeaturesMask |= (1ULL << Ext->Bit);
-  }
-  return FeaturesMask;
+uint64_t AArch64::getCpuSupportsMask(ArrayRef<StringRef> Features) {
+  ExtensionSet FeatureBits;
+  for (StringRef Feature : Features)
+    if (auto Ext = parseFMVExtension(Feature))
+      if (Ext->ID)
+        FeatureBits.enable(*Ext->ID);
----------------
labrinea wrote:

Apologies for the confusion. Architecture Extensions and Features are interchangable names as far as I understand.

>What is CPUFeatures? Is this an enum? Are those values define publicly in the ACLE/ABI?

Yes, here: llvm/include/llvm/TargetParser/AArch64CPUFeatures.inc

https://github.com/llvm/llvm-project/pull/119231