[llvm] [ASan] Add metadata to renamed instructions so ASan doesn't use the i… (PR #119387)

via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 07:31:37 PST 2024


================
@@ -123,6 +123,12 @@ ValueName *ValueSymbolTable::createValueName(StringRef Name, Value *V) {
   }
 
   // Otherwise, there is a naming conflict.  Rename this value.
+  // If we are renaming an instruction, ASan needs to know for it to serialize properly
----------------
gbMattN wrote:

ASan checks classes derived from Instruction, which is also derived from Value. So it is the name we store this instruction value under that is being changed.
I think that grammer works, but I will try reword to make it clearer.

https://github.com/llvm/llvm-project/pull/119387


More information about the llvm-commits mailing list