[llvm] [Offload][AMDGPU] accept generic target (PR #118919)

Shilei Tian via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 12:31:16 PST 2024


================
@@ -190,8 +190,8 @@ Error asyncMemCopy(bool UseMultipleSdmaEngines, void *Dst, hsa_agent_t DstAgent,
 #endif
 }
 
-Expected<std::string> getTargetTripleAndFeatures(hsa_agent_t Agent) {
-  std::string Target;
+Error getTargetTripleAndFeatures(hsa_agent_t Agent,
+                                 SmallVector<SmallString<32>> &Targets) {
----------------
shiltian wrote:

I don't see too much point of using `SmallString` here because every use of it is to convert it to `std::string`.

https://github.com/llvm/llvm-project/pull/118919


More information about the llvm-commits mailing list