[llvm] [ADT] Skip destroying trivially destructible values in DenseMap (PR #106934)
David Blaikie via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 9 12:17:07 PST 2024
dwblaikie wrote:
> > > Test?
> >
> >
> > Not sure this is testable? If they're trivially destructible, it wouldn't be possible to observe the difference between destroying them and not destroying them, right?
>
> We could have the test for the non-trivially destructible case to make sure we don't unintentionally skip destructors. If we already do, it would be good to point out in the PR description.
Sure, that'd be nice - good call.
https://github.com/llvm/llvm-project/pull/106934
More information about the llvm-commits
mailing list