[llvm] SimplifyLibCalls: Use default globals address space when building new global strings. (PR #118729)

[Jessica Clarke via llvm-commits]

================
@@ -0,0 +1,35 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; Test that the printf library call simplifier works correctly.
+;
+; RUN: opt < %s -passes=instcombine -S | FileCheck %s
+
+target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128-G200"
+
+ at hello_world = addrspace(200) constant [13 x i8] c"hello world\0A\00"
+ at percent_s = addrspace(200) constant [4 x i8] c"%s\0A\00"
+
+declare i32 @printf(ptr addrspace(200) , ...)
+declare i32 @puts(ptr addrspace(200))
----------------
jrtc27 wrote:

See https://github.com/llvm/llvm-project/pull/88182 for some related discussion, in particular https://github.com/llvm/llvm-project/pull/88182#issuecomment-2045975125 onwards. It's important for anyone trying to upstream CHERI-related things to be aware of past discussion on this topic, and unless you want to search the internet for everything related to CHERI you only get that by talking to the people who have been involved in those kinds of discussions.

https://github.com/llvm/llvm-project/pull/118729