[llvm] Store sysreg names in-line with their descriptors. (PR #119157)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 9 03:10:08 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-aarch64
@llvm/pr-subscribers-backend-arm
Author: Owen Anderson (resistor)
<details>
<summary>Changes</summary>
This wastes some disk space, because we have to size the arrays for
the maximum possible length. However, it eliminates dynamic relocations
from the SysRegsList arrays.
---
Full diff: https://github.com/llvm/llvm-project/pull/119157.diff
3 Files Affected:
- (modified) llvm/lib/Target/AArch64/Utils/AArch64BaseInfo.h (+2-2)
- (modified) llvm/lib/Target/ARM/Utils/ARMBaseInfo.h (+1-1)
- (modified) llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h (+3-3)
``````````diff
diff --git a/llvm/lib/Target/AArch64/Utils/AArch64BaseInfo.h b/llvm/lib/Target/AArch64/Utils/AArch64BaseInfo.h
index 8f34cf054fe286..e0ccba4d6a59e8 100644
--- a/llvm/lib/Target/AArch64/Utils/AArch64BaseInfo.h
+++ b/llvm/lib/Target/AArch64/Utils/AArch64BaseInfo.h
@@ -700,8 +700,8 @@ AArch64StringToVectorLayout(StringRef LayoutStr) {
namespace AArch64SysReg {
struct SysReg {
- const char *Name;
- const char *AltName;
+ const char Name[32];
+ const char AltName[32];
unsigned Encoding;
bool Readable;
bool Writeable;
diff --git a/llvm/lib/Target/ARM/Utils/ARMBaseInfo.h b/llvm/lib/Target/ARM/Utils/ARMBaseInfo.h
index 56a925f09ea7ae..5562572c5abf48 100644
--- a/llvm/lib/Target/ARM/Utils/ARMBaseInfo.h
+++ b/llvm/lib/Target/ARM/Utils/ARMBaseInfo.h
@@ -189,7 +189,7 @@ inline static unsigned ARMCondCodeFromString(StringRef CC) {
// System Registers
namespace ARMSysReg {
struct MClassSysReg {
- const char *Name;
+ const char Name[32];
uint16_t M1Encoding12;
uint16_t M2M3Encoding8;
uint16_t Encoding;
diff --git a/llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h b/llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h
index 9e36d62352ae51..fe28195654fdea 100644
--- a/llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h
+++ b/llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h
@@ -449,9 +449,9 @@ int getLoadFPImm(APFloat FPImm);
namespace RISCVSysReg {
struct SysReg {
- const char *Name;
- const char *AltName;
- const char *DeprecatedName;
+ const char Name[32];
+ const char AltName[32];
+ const char DeprecatedName[32];
unsigned Encoding;
// FIXME: add these additional fields when needed.
// Privilege Access: Read, Write, Read-Only.
``````````
</details>
https://github.com/llvm/llvm-project/pull/119157
More information about the llvm-commits
mailing list