[llvm] IVDesc: unify RecurKinds IAnyOf and FAnyOf (PR #118393)
Mel Chen via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 9 02:55:08 PST 2024
================
@@ -500,7 +497,7 @@ bool RecurrenceDescriptor::AddReductionVar(
// This means we have seen one but not the other instruction of the
// pattern or more than just a select and cmp. Zero implies that we saw a
// llvm.min/max intrinsic, which is always OK.
- if (isMinMaxRecurrenceKind(Kind) && NumCmpSelectPatternInst != 2 &&
+ if (isMinMaxRecurrenceKind(Kind) && NumCmpSelectPatternInst != 1 &&
----------------
Mel-Chen wrote:
I realize that removing `NumCmpSelectPatternInst` might not be as straightforward as I initially thought.
Could we instead separate the changes related to AnyOf and modify them independently? I’d prefer not to introduce changes to other reduction behaviors while working on AnyOf.
https://github.com/llvm/llvm-project/pull/118393
More information about the llvm-commits
mailing list