[llvm] [offload] Standalone build fixes (PR #118173)

Jan Patrick Lehr via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 05:13:15 PST 2024


=?utf-8?q?Michał_Górny?= <mgorny at gentoo.org>,
=?utf-8?q?Michał_Górny?= <mgorny at gentoo.org>,
=?utf-8?q?Michał_Górny?= <mgorny at gentoo.org>,
=?utf-8?q?Michał_Górny?= <mgorny at gentoo.org>,
=?utf-8?q?Michał_Górny?= <mgorny at gentoo.org>,
=?utf-8?q?Michał_Górny?= <mgorny at gentoo.org>,
=?utf-8?q?Michał_Górny?= <mgorny at gentoo.org>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/118173 at github.com>


jplehr wrote:

> > I personally would appreciate to rebase this PR and add the changes required to work with the libc patch. Don't know how difficult that will be though.
> 
> Actually, the right approach would be to fix the libc path not to use `LLVM_MAIN_SRC_DIR` (after all, it's not using `llvm` subdirectory at all), and instead declare a path relative to `CMAKE_CURRENT_SOURCE_DIR`, much like `LLVM_COMMON_CMAKE_UTILS` is declared now.

We could key off of `devicertl_base_directory` which is already used in those places.

https://github.com/llvm/llvm-project/pull/118173


More information about the llvm-commits mailing list