[llvm] [X86] Recognize POP/ADD/SUB modifying rsp in getSPAdjust. (PR #114265)
Phoebe Wang via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 21 07:22:34 PST 2024
phoebewang wrote:
> And I was probably a bit too harsh when talking about "people that aren't following up on problems found when landing patches". We can't expect everyone to be on high alert on any email notification X days after having submitted something (this wasn't even detected by the buildbots afaik). And Daniel did end up responding here. Just frustrating when you have a problem and don't even know if the submitter has gone fishing for the next couple of weeks (and you can't even see who the notifications are sent to).
We should be more generous to new contributors, they will learn it sooner or later. And you don't necessarily wait for author's response before reverting it.
https://github.com/llvm/llvm-project/pull/114265
More information about the llvm-commits
mailing list