[llvm] [X86] Recognize POP/ADD/SUB modifying rsp in getSPAdjust. (PR #114265)

Björn Pettersson via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 21 05:26:51 PST 2024


bjope wrote:

> > @phoebewang, @RKSimon and @e-kud : I can't even see that @daniel-zabawa has a registered email address. So unsure if pinging here actually will lead to anything? I guess we shouldn't accept patches from people that aren't following up on problems found when landing patches?
> 
> @bjope Do you mean an email address shown in the GitHub? I think it's hidden by default. You can find the email address from `git log`.

Well, I kind of thought that I would see it in the email notification I got myself when I had used @ to cc someone (i.e. that I would see who else got that email). But I guess it is completely hidden then.

And I was probably a bit too harsh when talking about "people that aren't following up on problems found when landing patches". We can't expect everyone to be on high alert on any email notification X days after having submitted something (this wasn't even detected by the buildbots afaik). And Daniel did end up responding here. Just frustrating when you have a problem and don't even know if the submitter has gone fishing for the next couple of weeks (and you can't even see who the notifications are sent to).


https://github.com/llvm/llvm-project/pull/114265


More information about the llvm-commits mailing list