[llvm] [ARM] Stop gluing VFP comparisons to FMSTAT (PR #116676)

Sergei Barannikov via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 07:20:08 PST 2024


s-barannikov wrote:

> It looks as if the `FMSTAT` is no longer glued to the `VCMP` before it, but _is_ still glued to whatever uses its output PSR flags? (Based on the fact that `duplicateCmp` is still generating an `MVT::Glue` as output, and indeed needs to exist at all.)

That's true, and I was going to fix it in the next patch. Unfortunately the patch will not be small, because changing this particular glue requires changing operands of BRCOND/CSINC/CSEL and all the others simultaneously. Otherwise, I'd have to insert copies and that would break DAG combiner logic.

> Not a complaint – I don't want to be one of those code reviewers who won't accept a small improvement until it's turned into a much bigger one :-) but it might be a thing to call out in the commit message to avoid confusion.

Sure, there are a couple more things I would also like to point out.


https://github.com/llvm/llvm-project/pull/116676


More information about the llvm-commits mailing list