[llvm] [ARM] Stop gluing VFP comparisons to FMSTAT (PR #116676)

Simon Tatham via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 07:09:56 PST 2024


statham-arm wrote:

It looks as if the `FMSTAT` is no longer glued to the `VCMP` before it, but _is_ still glued to whatever uses its output PSR flags? (Based on the fact that `duplicateCmp` is still generating an `MVT::Glue` as output, and indeed needs to exist at all.)

Not a complaint – I don't want to be one of those code reviewers who won't accept a small improvement until it's turned into a much bigger one :-) but it might be a thing to call out in the commit message to avoid confusion.

https://github.com/llvm/llvm-project/pull/116676


More information about the llvm-commits mailing list