[compiler-rt] [win/asan] Support instructions in GetInstructionSize used by Wine. (PR #113085)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 02:17:11 PST 2024


mstorsjo wrote:

> > If this interacts with [8417f6a](https://github.com/llvm/llvm-project/commit/8417f6af54c8f6dcf5893ab1352b50bf33c5a1ba), can you rebase this change past that, to make things clearer with how it fits together with that?
> 
> Since the comment "v4" it is already rebased behind [8417f6a](https://github.com/llvm/llvm-project/commit/8417f6af54c8f6dcf5893ab1352b50bf33c5a1ba), so this should make no problems. But I see now there was another commit to this file in [cdfd4cf](https://github.com/llvm/llvm-project/commit/cdfd4cff555db532a9001662fc8d6a7b05f1c2c3). It seems to make no conflict, but should I still rebase over this one?
> 
> Thanks for having a look. So should I mark this PR as draft again, and feed in separate PRs for easier review?

Ah, ok, I see.

As I'm not qualified enough to really review this, I would hold off of updating it until some of those who might be (@rnk, @zmodem, @vitalybuka or @barcharcraz) says which way they prefer to handle it.

As for adding the extra `#if`s to silence warnings due to the unused code blocks - just file that in a separate PR which I can accept quite quickly.

https://github.com/llvm/llvm-project/pull/113085


More information about the llvm-commits mailing list