[compiler-rt] [win/asan] Support instructions in GetInstructionSize used by Wine. (PR #113085)
Martin Storsjö via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 19 02:15:31 PST 2024
================
@@ -658,7 +681,6 @@ static size_t GetInstructionSize(uptr address, size_t* rel_offset = nullptr) {
}
switch (0x00FFFFFF & *(u32*)address) {
- case 0x07c1f6: // f6 c1 07 : test cl, 0x7
----------------
mstorsjo wrote:
Ah, I see - so this should ideally be reviewed as a series of individual patches, rather than looking at the total result of this PR. The policy within llvm is (IMO unfortunately) that PRs are merged with "squash and merge" only, so the incoming distinction between individual commits is lost on merge, and most reviewers probably don't look at it with a per-commit view (unless told to).
https://github.com/llvm/llvm-project/pull/113085
More information about the llvm-commits
mailing list