[llvm] [PDB] Fix missing `consumeError` which raise error with asserts enabled (PR #116480)

[Alexandre Ganea via llvm-commits]

aganea wrote:

> I can't share the PDB that triggers this code path but the changes are pretty conservative and idiomatic with other `consumeError` used in this source file.

Are you able nevertheless to craft a reduced test that exercices this codepath? There's quite a few examples in https://github.com/llvm/llvm-project/tree/main/llvm/test/DebugInfo/PDB (please see the Inputs folder as well). But I wonder if yaml2pdb would forcibly write the publics stream, if that's the issue.

https://github.com/llvm/llvm-project/pull/116480