[llvm] a52cb0a - [PDB] Fix missing `consumeError` which raise error with asserts enabled (#116480)

[via llvm-commits]

Author: Romain Thomas
Date: 2024-11-18T15:23:10+01:00
New Revision: a52cb0a2b9c44cdd3b36e414b8d2b809ec8b2ec8

URL: https://github.com/llvm/llvm-project/commit/a52cb0a2b9c44cdd3b36e414b8d2b809ec8b2ec8
DIFF: https://github.com/llvm/llvm-project/commit/a52cb0a2b9c44cdd3b36e414b8d2b809ec8b2ec8.diff

LOG: [PDB] Fix missing `consumeError` which raise error with asserts enabled (#116480)

As mentioned in the title, the missing `consumeError` triggers assertions.

Added: 
    

Modified: 
    llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp b/llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp
index 463b9ebe3cbff5..95b95a5bbc509f 100644
--- a/llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp
+++ b/llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp
@@ -388,12 +388,16 @@ SymbolCache::findPublicSymbolBySectOffset(uint32_t Sect, uint32_t Offset) {
     return getSymbolById(Iter->second);
 
   auto Publics = Session.getPDBFile().getPDBPublicsStream();
-  if (!Publics)
+  if (!Publics) {
+    consumeError(Publics.takeError());
     return nullptr;
+  }
 
   auto ExpectedSyms = Session.getPDBFile().getPDBSymbolStream();
-  if (!ExpectedSyms)
+  if (!ExpectedSyms) {
+    consumeError(ExpectedSyms.takeError());
     return nullptr;
+  }
   BinaryStreamRef SymStream =
       ExpectedSyms->getSymbolArray().getUnderlyingStream();