[llvm] [libc++] Stop uploading crash diagnostics in the CI (PR #116581)

via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 17 23:09:53 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-github-workflow

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

<details>
<summary>Changes</summary>

This seems to break the CI right now, and I've never once used those artifacts to debug something. In case of problems, we could always just modify a failing PR to include the required crash diagnostics in the artifacts as a one-off thing.

---
Full diff: https://github.com/llvm/llvm-project/pull/116581.diff


1 Files Affected:

- (modified) .github/workflows/libcxx-build-and-test.yaml (-5) 


``````````diff
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 472d18e73da78d..6275fc45721e09 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -43,7 +43,6 @@ env:
   LLVM_OLDEST_VERSION: "17"
   GCC_STABLE_VERSION: "13"
   LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-19"
-  CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
 
 jobs:
   stage1:
@@ -82,7 +81,6 @@ jobs:
             **/CMakeConfigureLog.yaml
             **/CMakeError.log
             **/CMakeOutput.log
-            **/crash_diagnostics/*
   stage2:
     if: github.repository_owner == 'llvm'
     runs-on: libcxx-self-hosted-linux
@@ -128,7 +126,6 @@ jobs:
             **/CMakeConfigureLog.yaml
             **/CMakeError.log
             **/CMakeOutput.log
-            **/crash_diagnostics/*
   stage3:
     if: github.repository_owner == 'llvm'
     needs: [ stage1, stage2 ]
@@ -192,7 +189,6 @@ jobs:
             **/CMakeConfigureLog.yaml
             **/CMakeError.log
             **/CMakeOutput.log
-            **/crash_diagnostics/*
 
   macos:
     needs: [ stage1 ]
@@ -235,7 +231,6 @@ jobs:
             **/CMakeConfigureLog.yaml
             **/CMakeError.log
             **/CMakeOutput.log
-            **/crash_diagnostics/*
 
   windows:
     runs-on: windows-2022

``````````

</details>


https://github.com/llvm/llvm-project/pull/116581


More information about the llvm-commits mailing list