[llvm] [libc++] Stop uploading crash diagnostics in the CI (PR #116581)

Louis Dionne via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 17 23:09:15 PST 2024


https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/116581

This seems to break the CI right now, and I've never once used those artifacts to debug something. In case of problems, we could always just modify a failing PR to include the required crash diagnostics in the artifacts as a one-off thing.

>From e1d639125e490216349eb6095409388f3d591e36 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Mon, 18 Nov 2024 08:04:14 +0100
Subject: [PATCH] [libc++] Stop uploading crash diagnostics in the CI

This seems to break the CI right now, and I've never once used
those artifacts to debug something. In case of problems, we could
always just modify a failing PR to include the required crash
diagnostics in the artifacts as a one-off thing.
---
 .github/workflows/libcxx-build-and-test.yaml | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 472d18e73da78d..6275fc45721e09 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -43,7 +43,6 @@ env:
   LLVM_OLDEST_VERSION: "17"
   GCC_STABLE_VERSION: "13"
   LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-19"
-  CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
 
 jobs:
   stage1:
@@ -82,7 +81,6 @@ jobs:
             **/CMakeConfigureLog.yaml
             **/CMakeError.log
             **/CMakeOutput.log
-            **/crash_diagnostics/*
   stage2:
     if: github.repository_owner == 'llvm'
     runs-on: libcxx-self-hosted-linux
@@ -128,7 +126,6 @@ jobs:
             **/CMakeConfigureLog.yaml
             **/CMakeError.log
             **/CMakeOutput.log
-            **/crash_diagnostics/*
   stage3:
     if: github.repository_owner == 'llvm'
     needs: [ stage1, stage2 ]
@@ -192,7 +189,6 @@ jobs:
             **/CMakeConfigureLog.yaml
             **/CMakeError.log
             **/CMakeOutput.log
-            **/crash_diagnostics/*
 
   macos:
     needs: [ stage1 ]
@@ -235,7 +231,6 @@ jobs:
             **/CMakeConfigureLog.yaml
             **/CMakeError.log
             **/CMakeOutput.log
-            **/crash_diagnostics/*
 
   windows:
     runs-on: windows-2022



More information about the llvm-commits mailing list