[llvm] [SROA] Fix NumPromoted statistic for SROA pass. (PR #115586)

via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 8 22:11:21 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-transforms

Author: Afanasyev Ivan (ivafanas)

<details>
<summary>Changes</summary>

`NumPromoted` stat should not be increased if `SROASkipMem2Reg` is set and nothing is changed.

---
Full diff: https://github.com/llvm/llvm-project/pull/115586.diff


1 Files Affected:

- (modified) llvm/lib/Transforms/Scalar/SROA.cpp (+1-2) 


``````````diff
diff --git a/llvm/lib/Transforms/Scalar/SROA.cpp b/llvm/lib/Transforms/Scalar/SROA.cpp
index 3b01089962e29c..4a23e2bee5ba25 100644
--- a/llvm/lib/Transforms/Scalar/SROA.cpp
+++ b/llvm/lib/Transforms/Scalar/SROA.cpp
@@ -5590,12 +5590,11 @@ bool SROA::promoteAllocas(Function &F) {
   if (PromotableAllocas.empty())
     return false;
 
-  NumPromoted += PromotableAllocas.size();
-
   if (SROASkipMem2Reg) {
     LLVM_DEBUG(dbgs() << "Not promoting allocas with mem2reg!\n");
   } else {
     LLVM_DEBUG(dbgs() << "Promoting allocas with mem2reg...\n");
+    NumPromoted += PromotableAllocas.size();
     PromoteMemToReg(PromotableAllocas.getArrayRef(), DTU->getDomTree(), AC);
   }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/115586


More information about the llvm-commits mailing list