[llvm] [InstCombine] Optimistically allow multiple shufflevector uses in foldOpPhi (PR #114278)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 8 05:28:11 PST 2024


https://github.com/nikic commented:

If I'm reading this correctly, then nothing here actually guarantees that *all* shufflevectors are going to simplify? You just check that all uses are shufflevectors, but then simplify each individually.

If we say that we consider it profitable to replace a shufflevector with a phi in general, then we shouldn't need the check on the uses for shufflevectors at all.

https://github.com/llvm/llvm-project/pull/114278


More information about the llvm-commits mailing list