[llvm] [mlir] Fix nested codeowners for vector dialect (PR #115473)

Kunwar Grover via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 8 04:51:48 PST 2024


https://github.com/Groverkss created https://github.com/llvm/llvm-project/pull/115473

Due to how CODEOWNERS works, if a file matches two rules, the later rule will take precedence.

Because of this, /mlir/include/mlir/Dialect/Vector rules were not matching against /mlir/include/mlir/Dialect/Vector/IR .

This patch adds users in the directory rules, to the finer grained rules, which I'm guessing was the intended effect that they expected when they were added.

>From f24141a54a783f907cfd9ffb1f85cc00c9a770bc Mon Sep 17 00:00:00 2001
From: Kunwar Grover <groverkss at gmail.com>
Date: Fri, 8 Nov 2024 12:51:36 +0000
Subject: [PATCH] [mlir] Fix nested codeowners for vector dialect

Due to how CODEOWNERS works, if a file matches two rules, the later rule will take precedence.

Because of this, /mlir/include/mlir/Dialect/Vector rules were not matching against /mlir/include/mlir/Dialect/Vector/IR .

This patch adds users in the directory rules, to the finer grained rules, which I'm guessing was the intended effect that they expected when they were added.
---
 .github/CODEOWNERS | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index 018b64364e284b..8cdc49ebfa712e 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -83,10 +83,10 @@
 /mlir/**/*VectorToLLVM* @banach-space @dcaballe @nicolasvasilache
 /mlir/**/*X86Vector* @aartbik @dcaballe @nicolasvasilache
 /mlir/include/mlir/Dialect/Vector @banach-space @dcaballe @nicolasvasilache @Groverkss
-/mlir/include/mlir/Dialect/Vector/IR @kuhar
+/mlir/include/mlir/Dialect/Vector/IR @kuhar @banach-space @dcaballe @nicolasvasilache @Groverkss
 /mlir/lib/Dialect/Vector @banach-space @dcaballe @nicolasvasilache @Groverkss
-/mlir/lib/Dialect/Vector/Transforms/* @banach-space @dcaballe @hanhanW @nicolasvasilache
-/mlir/lib/Dialect/Vector/Transforms/VectorEmulateNarrowType.cpp @banach-space @dcaballe @MaheshRavishankar @nicolasvasilache
+/mlir/lib/Dialect/Vector/Transforms/* @banach-space @dcaballe @hanhanW @nicolasvasilache @Groverkss
+/mlir/lib/Dialect/Vector/Transforms/VectorEmulateNarrowType.cpp @banach-space @dcaballe @hanhanW @MaheshRavishankar @nicolasvasilache @Groverkss
 /mlir/**/*EmulateNarrowType* @dcaballe @hanhanW
 
 # Presburger library in MLIR



More information about the llvm-commits mailing list