[llvm] [MemProf] Avoid incorrect ICP symtab canonicalization (PR #115419)

[Snehasish Kumar via llvm-commits]

================
@@ -640,9 +641,11 @@ Error InstrProfSymtab::addFuncWithName(Function &F, StringRef PGOFuncName) {
   if (Error E = NameToGUIDMap(PGOFuncName))
     return E;
 
-  StringRef CanonicalFuncName = getCanonicalName(PGOFuncName);
-  if (CanonicalFuncName != PGOFuncName)
-    return NameToGUIDMap(CanonicalFuncName);
+  if (AddCanonical) {
----------------
snehasish wrote:

Maybe early return with an inverted condition to avoid nesting below?

`if(!AddCanonical) return Error::success`

https://github.com/llvm/llvm-project/pull/115419