[llvm] [SPIRV] Audit `select` Result in SPIRVInstructionSelector (PR #115193)

[Sarah Spall via llvm-commits]

================
@@ -1205,21 +1219,22 @@ bool SPIRVInstructionSelector::selectOverflowArith(Register ResVReg,
             .addUse(GR.getSPIRVTypeID(ResType))
             .addUse(StructVReg)
             .addImm(i);
-    Status &= MIB.constrainAllUses(TII, TRI, RBI);
+    Result &= MIB.constrainAllUses(TII, TRI, RBI);
   }
   // Build boolean value from the higher part.
-  Status &= BuildMI(BB, I, I.getDebugLoc(), TII.get(SPIRV::OpINotEqual))
+  Result &= BuildMI(BB, I, I.getDebugLoc(), TII.get(SPIRV::OpINotEqual))
----------------
spall wrote:

I would do 'return Result && BuildMI', instead of returning later.

https://github.com/llvm/llvm-project/pull/115193