[llvm] [NVPTX] Fix lowering of i1 SETCC (PR #115035)
Justin Fargnoli via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 7 13:30:08 PST 2024
================
@@ -668,6 +668,11 @@ NVPTXTargetLowering::NVPTXTargetLowering(const NVPTXTargetMachine &TM,
setTruncStoreAction(VT, MVT::i1, Expand);
}
+ setCondCodeAction({ISD::SETNE, ISD::SETEQ, ISD::SETUGE, ISD::SETULE,
+ ISD::SETUGT, ISD::SETULT, ISD::SETGT, ISD::SETLT,
+ ISD::SETGE, ISD::SETLE},
+ MVT::i1, Custom);
----------------
justinfargnoli wrote:
If it makes sense for something to live in `.../CodeGen/SelectionDAG/*`, I think we should implement it there instead of in `.../Target/NVPTX/*`.
This is also my assumption of what @arsenm was asking for [above](https://github.com/llvm/llvm-project/pull/115035#discussion_r1829788004).
CC @arsenm to correct me.
https://github.com/llvm/llvm-project/pull/115035
More information about the llvm-commits
mailing list