[compiler-rt] [compiler-rt][RISCV] Avoid using __init_riscv_feature_bits as a direc… (PR #115316)

Sam Elliott via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 7 06:01:26 PST 2024


https://github.com/lenary approved this pull request.

Sounds reasonable to me.

Given your recent update to the wording in C api, can you check that the lengths are being left as zero until e.g. hwprobes are successful? The setting of lengths on (new) line 359/360 looks a little strange to me, given (new) line 369 seems to return if `initHwProbe` fails.

https://github.com/llvm/llvm-project/pull/115316


More information about the llvm-commits mailing list