[llvm] [IR][Attributes] Take "best" from Callbase/Call Function when getting attributes (PR #112985)

[David Green via llvm-commits]

================
@@ -443,4 +443,4 @@ declare void @end_struct_large_nonchar()
 declare signext i16 @get_struct_small_nonchar()
 declare void @end_struct_small_nonchar()
 
-declare void @takes_all(i64, i16, ptr byval(%struct.struct_large_nonchar) align 8, i32, ptr, ptr, ptr, ptr, ptr, i32, i32, i32)
+declare void @takes_all(i64, i16, ptr byval(%struct.struct_large_nonchar) align 4, i32, ptr, ptr, ptr, ptr, ptr, i32, i32, i32)
----------------
davemgreen wrote:

Sorry, I didn't see this until now. This test is very old now but considering what it does, yes this sounds OK.

https://github.com/llvm/llvm-project/pull/112985