[lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

Pavel Labath via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 7 01:29:05 PST 2024


================
@@ -46,6 +48,7 @@ class DWARFBaseDIE {
   explicit operator bool() const { return IsValid(); }
 
   bool IsValid() const { return m_cu && m_die; }
+  bool isValid() const { return IsValid(); }
----------------
labath wrote:

I'm sorry, I guess I wasn't clear about this. What I was suggesting is to just revert the addition `isValid` -- as there already exists a comon API. I didn't want to remove things that are already there. (I mean, I'd be fine with that doing that under the flag of moving the LLDB API closer to LLVM, but I don't think we ought to do that as a part of this PR)

https://github.com/llvm/llvm-project/pull/112811


More information about the llvm-commits mailing list