[llvm] [llvm] Use computeConstantRange to improve llvm.objectsize computation (PR #114673)
Harald van Dijk via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 7 01:14:54 PST 2024
hvdijk wrote:
I did write
> just make sure that when you merge and squash, you do not accidentally overwrite your correct commit message with the older PR description :)
for a reason, I have been bit by this before. https://github.com/llvm/llvm-project/commit/f30f00ab43e0c28d79f12170978330ee5d7901b0 had a correct commit message, the squashed https://github.com/llvm/llvm-project/commit/5f342816efe1854333f2be41a03fdd25fa0db433 has an incorrect commit message.
It is fine, this has happened before and will happen again, but it is good for us to be aware of it.
https://github.com/llvm/llvm-project/pull/114673
More information about the llvm-commits
mailing list