[llvm] [Utils] Avoid repeated hash lookups (NFC) (PR #115262)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 6 20:22:38 PST 2024
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/115262
None
>From 555294c71f6eb4a62552aed3b8ea9d5f301ab3cd Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Wed, 6 Nov 2024 08:46:49 -0800
Subject: [PATCH] [Utils] Avoid repeated hash lookups (NFC)
---
llvm/lib/Transforms/Utils/Local.cpp | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/llvm/lib/Transforms/Utils/Local.cpp b/llvm/lib/Transforms/Utils/Local.cpp
index 47a70492559610..768765b6c1e632 100644
--- a/llvm/lib/Transforms/Utils/Local.cpp
+++ b/llvm/lib/Transforms/Utils/Local.cpp
@@ -2178,11 +2178,9 @@ void llvm::insertDebugValuesForPHIs(BasicBlock *BB,
auto V = DbgValueMap.find(VI);
if (V != DbgValueMap.end()) {
auto *DbgII = cast<DbgVariableIntrinsic>(V->second);
- auto NewDI = NewDbgValueMap.find({Parent, DbgII});
- if (NewDI == NewDbgValueMap.end()) {
- auto *NewDbgII = cast<DbgVariableIntrinsic>(DbgII->clone());
- NewDI = NewDbgValueMap.insert({{Parent, DbgII}, NewDbgII}).first;
- }
+ auto [NewDI, Inserted] = NewDbgValueMap.try_emplace({Parent, DbgII});
+ if (Inserted)
+ NewDI->second = cast<DbgVariableIntrinsic>(DbgII->clone());
DbgVariableIntrinsic *NewDbgII = NewDI->second;
// If PHI contains VI as an operand more than once, we may
// replaced it in NewDbgII; confirm that it is present.
More information about the llvm-commits
mailing list