[llvm] [OpenMP] Add missing SExt attributes on __kmpc_omp_taskwait_deps_51 args. (PR #115242)
Jonas Paulsson via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 6 16:29:08 PST 2024
https://github.com/JonPsson1 created https://github.com/llvm/llvm-project/pull/115242
Add missing sign extension attributes to function i32 arguments.
CC:ing some people I see in the commit log for the file, with the hopes of a review:
@EthanLuisMcDonough @sushgokh @doru1004 @jhuber6 @DominikAdamski @jdoerfert
>From 993738b84a1ed5963d32d4198f14c78c1993a716 Mon Sep 17 00:00:00 2001
From: Jonas Paulsson <paulson1 at linux.ibm.com>
Date: Wed, 6 Nov 2024 17:42:59 -0600
Subject: [PATCH] Add missing SExt attributes on __kmpc_omp_taskwait_deps_51
args.
---
llvm/include/llvm/Frontend/OpenMP/OMPKinds.def | 3 ++-
llvm/test/Transforms/OpenMP/add_attributes.ll | 5 +++++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/llvm/include/llvm/Frontend/OpenMP/OMPKinds.def b/llvm/include/llvm/Frontend/OpenMP/OMPKinds.def
index d8f3c8fa06b747..6f26f853eca032 100644
--- a/llvm/include/llvm/Frontend/OpenMP/OMPKinds.def
+++ b/llvm/include/llvm/Frontend/OpenMP/OMPKinds.def
@@ -946,7 +946,8 @@ __OMP_RTL_ATTRS(__kmpc_proxy_task_completed_ooo, DefaultAttrs, AttributeSet(),
__OMP_RTL_ATTRS(__kmpc_omp_wait_deps, BarrierAttrs, AttributeSet(),
ParamAttrs(ReadOnlyPtrAttrs, SExt, SExt, ReadOnlyPtrAttrs, SExt))
__OMP_RTL_ATTRS(__kmpc_omp_taskwait_deps_51, BarrierAttrs, AttributeSet(),
- ParamAttrs(ReadOnlyPtrAttrs, SExt, SExt, ReadOnlyPtrAttrs))
+ ParamAttrs(ReadOnlyPtrAttrs, SExt, SExt, ReadOnlyPtrAttrs, SExt,
+ AttributeSet(), SExt))
__OMP_RTL_ATTRS(__kmpc_cancellationpoint, DefaultAttrs, SExt,
ParamAttrs(ReadOnlyPtrAttrs, SExt, SExt))
diff --git a/llvm/test/Transforms/OpenMP/add_attributes.ll b/llvm/test/Transforms/OpenMP/add_attributes.ll
index fefb1900afae7e..ce28643267a6a5 100644
--- a/llvm/test/Transforms/OpenMP/add_attributes.ll
+++ b/llvm/test/Transforms/OpenMP/add_attributes.ll
@@ -589,6 +589,8 @@ declare i32 @__kmpc_omp_task_with_deps(ptr, i32, ptr, i32, ptr, i32, ptr)
declare void @__kmpc_omp_wait_deps(ptr, i32, i32, ptr, i32, ptr)
+declare void @__kmpc_omp_taskwait_deps_51(ptr, i32, i32, ptr, i32, ptr, i32)
+
declare i32 @__kmpc_cancellationpoint(ptr, i32, i32)
declare void @__kmpc_push_num_teams(ptr, i32, i32, i32)
@@ -2465,6 +2467,9 @@ declare i32 @__tgt_target_kernel_nowait(ptr, i64, i32, i32, ptr, ptr, i32, ptr,
; EXT: ; Function Attrs: convergent nounwind
; EXT-NEXT: declare void @__kmpc_omp_wait_deps(ptr, i32 signext, i32 signext, ptr, i32 signext, ptr)
+; EXT: ; Function Attrs: convergent nounwind
+; EXT-NEXT: declare void @__kmpc_omp_taskwait_deps_51(ptr, i32 signext, i32 signext, ptr, i32 signext, ptr, i32 signext)
+
; EXT: ; Function Attrs: nounwind
; EXT-NEXT: declare signext i32 @__kmpc_cancellationpoint(ptr, i32 signext, i32 signext)
More information about the llvm-commits
mailing list