[llvm] [dsymutil] Add missing newlines in error messages. (PR #115191)

Ryan Mansfield via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 6 10:35:29 PST 2024


https://github.com/rjmansfield created https://github.com/llvm/llvm-project/pull/115191

Errors like "cannot create bundle: Not a directory" or "error: a.out.dSYM: Is a directory" were being emitted without a newline.

>From 97d370b466364860a2a79b687da48e06c4566389 Mon Sep 17 00:00:00 2001
From: Ryan Mansfield <ryan_mansfield at apple.com>
Date: Wed, 6 Nov 2024 13:31:17 -0500
Subject: [PATCH] [dsymutil] Add missing newlines in error messages.

---
 llvm/tools/dsymutil/dsymutil.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/tools/dsymutil/dsymutil.cpp b/llvm/tools/dsymutil/dsymutil.cpp
index 754d3a0f26c3d1..2ace7180b00808 100644
--- a/llvm/tools/dsymutil/dsymutil.cpp
+++ b/llvm/tools/dsymutil/dsymutil.cpp
@@ -714,7 +714,7 @@ int dsymutil_main(int argc, char **argv, const llvm::ToolContext &) {
     Expected<OutputLocation> OutputLocationOrErr =
         getOutputFileName(InputFile, Options);
     if (!OutputLocationOrErr) {
-      WithColor::error() << toString(OutputLocationOrErr.takeError());
+      WithColor::error() << toString(OutputLocationOrErr.takeError()) << "\n";
       return EXIT_FAILURE;
     }
     Options.LinkOpts.ResourceDir = OutputLocationOrErr->getResourceDir();
@@ -792,7 +792,7 @@ int dsymutil_main(int argc, char **argv, const llvm::ToolContext &) {
               Options.LinkOpts.NoOutput ? "-" : OutputFile, EC,
               sys::fs::OF_None);
           if (EC) {
-            WithColor::error() << OutputFile << ": " << EC.message();
+            WithColor::error() << OutputFile << ": " << EC.message() << "\n";
             AllOK.fetch_and(false);
             return;
           }



More information about the llvm-commits mailing list