[llvm] [WebAssembly] Support multiple `.init_array` fragments when writing Wasm objects (PR #111008)

Sam Clegg via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 6 09:50:46 PST 2024


================
@@ -1769,6 +1769,11 @@ uint64_t WasmObjectWriter::writeOneObject(MCAssembler &Asm,
       WS.setIndex(InvalidIndex);
       continue;
     }
+    // Contents of .init_array sections are handled elsewhere.
+    if (WS.isDefined() &&
+        WS.getSection().getName().starts_with(".init_array")) {
----------------
sbc100 wrote:

What do you think about landing this PR without this part of the patch and then following up with another PR for e.g. "Handle symbols in init_array sections".

IIUC the test in this PR doesn't contain such symbols anyway so we would likely want a separate test anyway?

https://github.com/llvm/llvm-project/pull/111008


More information about the llvm-commits mailing list