[llvm] [FuncSpec] Query SCCPSolver in more places (PR #114964)

Hari Limaye via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 5 03:34:36 PST 2024


================
@@ -312,10 +317,10 @@ bool InstCostVisitor::discoverTransitivelyIncomingValues(
 
       // Disregard self-references and dead incoming values.
       if (auto *Inst = dyn_cast<Instruction>(V))
-        if (Inst == PN || DeadBlocks.contains(PN->getIncomingBlock(I)))
----------------
hazzlim wrote:

> Ah right, excuse me I had forgotten that. Then it makes sense. Can you use that function inside canEliminateSuccessor then?

Yep, will do this as well as updating things to be non-static/member functions, as per other comments.


https://github.com/llvm/llvm-project/pull/114964


More information about the llvm-commits mailing list